From 919bdff7ac09dc7ce8c8401684cfae743cc2691a Mon Sep 17 00:00:00 2001 From: Matthias Clasen Date: Sun, 5 Oct 2014 18:21:46 -0400 Subject: [PATCH] GdkDevice: Avoid unnecessary critical There is no need for a critical warning just because somebody asked for a property that is not meaningful for the device. Just document it as not useful for keyboard devices. --- gdk/gdkdevice.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gdk/gdkdevice.c b/gdk/gdkdevice.c index f30ebcc5bd..0647d9fd7e 100644 --- a/gdk/gdkdevice.c +++ b/gdk/gdkdevice.c @@ -688,6 +688,7 @@ gdk_device_get_name (GdkDevice *device) * @device: a #GdkDevice * * Determines whether the pointer follows device motion. + * This is not meaningful for keyboard devices, which don't have a pointer. * * Returns: %TRUE if the pointer follows device motion * @@ -697,7 +698,6 @@ gboolean gdk_device_get_has_cursor (GdkDevice *device) { g_return_val_if_fail (GDK_IS_DEVICE (device), FALSE); - g_return_val_if_fail (gdk_device_get_source (device) != GDK_SOURCE_KEYBOARD, FALSE); return device->has_cursor; } -- 2.30.2